Support parametrization from params or vars section in dvc.yaml#4751
Merged
skshetry merged 4 commits intoOct 20, 2020
Conversation
skshetry
added
enhancement
Collaborator
Author
|
Merged witout review, as I don't expect anyone to go through this large piece of code. Also, it's very core to the next iteration, and din't think of how I could split this (as this is already split). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
This PR was splitted from #4734, as it became quite large without the tests. I have also removed
foreachandsetsupport from there to reduce scope.This PR is also quite large, but the Context is well-tested and is about more than half of it. Though, I have left the tests for the newer syntax, which will come in separate PRs.