dvcignore: don't walk directories twice#5098
Merged
Merged
Conversation
efiop
changed the title
efiop
changed the title
Prevents us from duplicating the work by walking into directories searching for subrepos. Saves around ~1sec (5.8 -> 4.8) in `dvc metrics diff` in a big git-only repo. Related to treeverse#4284 (comment)
efiop
commented
Dec 14, 2020
|
|
||
| ignore_pattern = self._get_trie_pattern(root) | ||
| if ignore_pattern: | ||
| dirs, files = ignore_pattern(root, dirs, files) |
Contributor
Author
There was a problem hiding this comment.
dirs, files = ignore_pattern(root, dirs, files)
if not ignore_subrepos:
dirs.extend(self._ignored_subrepos.get(root, []))
This is a bit confusing, but I've decided not to touch this just yet.
efiop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents us from duplicating the work by walking into directories
searching for subrepos. Saves around ~1sec (5.8 -> 4.8) in
dvc metrics diffin a big git-only repo. And around ~2sec (9.7 -> 7.7)for
dvc statusin a repo with big undvcignored dirs.Related to #4284 (comment)
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏