params: introduce --targets#5122
Merged
Merged
Conversation
pared
force-pushed
the
4446_params_targets
branch
from
253d8e1 to
3086957
Compare
pared
force-pushed
the
4446_params_targets
branch
from
3086957 to
f1f5060
Compare
efiop
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
treeverse/dvc.org#2031
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes to #4446
This change addresses TODO list in original issue.
Besides that this change rolls back tests refactor introduced in #4837 - common tests made sense in case of metrics/plots to me, but in the end the parameterization, different usage of
showanddiffmade them unreadable and only filled the purpose of keepingmetrics/plotstests in single place. Now we would have to addtest_no_file_on_target_revfor params too, which would force another refactor. There are not that many tests there to justify this.