Skip to content

parametrization: fix error when the file in vars is a directory#5171

Merged
efiop merged 3 commits into
treeverse:masterfrom
skshetry:fix-error-on-directory
Dec 28, 2020
Merged

parametrization: fix error when the file in vars is a directory#5171
efiop merged 3 commits into
treeverse:masterfrom
skshetry:fix-error-on-directory

Conversation

@skshetry
Copy link
Copy Markdown
Collaborator

@skshetry skshetry commented Dec 28, 2020

Thank you for the contribution - we'll try to review it as soon as possible. 🙏


Fixes one issue pointed out on #5165.

The error will look something like following in case of top-level vars:

$ dvc repro
ERROR: failed to parse 'vars' in 'dvc.yaml': 'data' is a directory

@skshetry skshetry added bugfix fixes bug A: templating Related to the templating feature labels Dec 28, 2020
@skshetry skshetry requested review from efiop, pared and pmrowla December 28, 2020 10:09
@skshetry skshetry self-assigned this Dec 28, 2020
@efiop efiop merged commit 01a4473 into treeverse:master Dec 28, 2020
@skshetry skshetry deleted the fix-error-on-directory branch December 29, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: templating Related to the templating feature bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants