RepoTree: get rid if implicit fetching#5324
Merged
Merged
Conversation
efiop
commented
Jan 25, 2021
Comment on lines
103
to
109
Contributor
Author
There was a problem hiding this comment.
Strictly speaking this is not really needed, as cache.save() will fetch everything anyway, but I've added this for now because logic around this (e.g. tests) expects specific exceptions and also because this might be faster than save(), as we didn't optimize it yet. Need to check perf first, maybe we can remove it right now.
efiop
commented
Jan 25, 2021
11 tasks
5e5922a to
67172a8
Compare
efiop
commented
Jan 26, 2021
Comment on lines
+442
to
+443
| kw = kwargs.copy() | ||
| kw.pop("download_callback", None) |
Contributor
Author
There was a problem hiding this comment.
This is temporary, we'll start computing hash on-the-fly in the followup PRs.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we collect cache for pull/fetch or run status -c, we implicitly try to fetch the dir cache entry from the remote. And that's the behaviour that is expected from RepoTree too. There have been multiple times where we've tried to use Repo.repo_tree just to realise that it tries to fetch automatically, which is often not needed.
This PR is more of a POC that tries to get rid of
fetchflag and the implicit fetching during walk() that it implies in favor of just fetching stuff explicitly where we really need it (repo hasfetchmethod just for that already).Need to check performance and also 2
webdavtests fail now because they don't have open() support, and Tree doesn't fetch things automatically, as expected by the api code.Depends on #5307
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏