dvc: ignore errors on protect/set_exec#5335
Merged
Merged
Conversation
efiop
commented
Jan 26, 2021
Contributor
Author
There was a problem hiding this comment.
set_exec really belongs to checkout(e.g. it should be ignored for hardlinks/symlinks), but for now it is out of scope. It got affected in this PR because it was using the same chmod logic.
Both of these are not fatal and could safely be ignored. Fixes treeverse#5255
efiop
added a commit
that referenced
this pull request
Jan 26, 2021
efiop
added a commit
that referenced
this pull request
Jan 26, 2021
* dvc: ignore errors on protect/set_exec (#5335) Both of these are not fatal and could safely be ignored. Fixes #5255 (cherry picked from commit 434cd30) * tests: upgrade azurite and enable loose mode Backport of #5272 Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com> Co-authored-by: Ruslan Kuprieiev <ruslan@iterative.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of these are not fatal and could safely be ignored.
Fixes #5255
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏