plots: ignore binary plot files#5523
Merged
Merged
Conversation
efiop
reviewed
Feb 26, 2021
Comment on lines
90
to
106
Contributor
There was a problem hiding this comment.
We don't use warnings in metrics and params, right? If so, it is better to use debug() here too, for consistency.
pared
force-pushed
the
5490_plots_binary
branch
from
6d1f52c to
6783299
Compare
skshetry
reviewed
Feb 26, 2021
efiop
reviewed
Mar 1, 2021
Contributor
There was a problem hiding this comment.
There might be a chance that this will generate something that can be decoded as text. Better to just hardcode a particular blob here. It doesn't even need to be long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #5490