Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dvc/config_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class RelPath(str):
"session_token": str,
Optional("listobjects", default=False): Bool, # obsoleted
Optional("use_ssl", default=True): Bool,
Optional("ssl_verify", default=True): Bool,
"sse": str,
"sse_kms_key_id": str,
"acl": str,
Expand Down
2 changes: 2 additions & 0 deletions dvc/fs/s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def __init__(self, repo, config):
self.endpoint_url = config.get("endpointurl")

self.use_ssl = config.get("use_ssl", True)
self.ssl_verify = config.get("ssl_verify", True)

self.extra_args = {}

Expand Down Expand Up @@ -136,6 +137,7 @@ def s3(self):
return session.resource(
"s3",
endpoint_url=self.endpoint_url,
verify=self.ssl_verify,
use_ssl=self.use_ssl,
config=boto3.session.Config(
signature_version="s3v4", s3=s3_config
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/fs/test_s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ def test_init(dvc):
assert fs.path_info == url


def test_verify_ssl_default_param(dvc):
config = {
"url": url,
}
fs = S3FileSystem(dvc, config)

assert fs.ssl_verify


def test_ssl_verify_bool_param(dvc):
config = {"url": url, "ssl_verify": False}
fs = S3FileSystem(dvc, config)

assert fs.ssl_verify == config["ssl_verify"]


def test_grants(dvc):
config = {
"url": url,
Expand Down