Skip to content

webdav4: migrate to new library #6099

Merged
efiop merged 1 commit into
treeverse:masterfrom
skshetry:webdav4
Jun 4, 2021
Merged

webdav4: migrate to new library #6099
efiop merged 1 commit into
treeverse:masterfrom
skshetry:webdav4

Conversation

@skshetry
Copy link
Copy Markdown
Collaborator

@skshetry skshetry commented Jun 2, 2021

Here's the fetch speed comparison between the two libraries:

webdavclient3

asciicast

webdav4

asciicast

TODO:

  • Test ask_password still works
  • Test token auth works.
  • Test auth still works when the URL contains a username.
  • Test external remote case.
  • Test that it works if the server is accessed through a port.
  • Test that it works if the server is behind a path (i.e. not in root URL).
  • Test with Owncloud, NextCloud, and Yandex.
  • Test with certs.

Additionally, while we are at it, it'd be great to support:

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@skshetry skshetry added the fs: webdav Related to the Webdav filesystem label Jun 2, 2021
@skshetry skshetry self-assigned this Jun 2, 2021
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jun 2, 2021

Here's the fetch speed comparison between the two libraries:

@skshetry x100 faster? 😮 If so, could you elaborate on key differences that allowed you to achieve that?

@skshetry
Copy link
Copy Markdown
Collaborator Author

skshetry commented Jun 2, 2021

Here's the fetch speed comparison between the two libraries:

@skshetry x100 faster? If so, could you elaborate on key differences that allowed you to achieve that?

https://github.com/ezhov-evgeny/webdav-client-python-3/blob/09ae1414ddd331775686ebe55a625e732ef78b14/webdav3/client.py#L337

This has been recently fixed, but not released so far. Just a humblebrag. 😄

@skshetry skshetry force-pushed the webdav4 branch 2 times, most recently from df4ceec to 98a8532 Compare June 3, 2021 11:14
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jun 4, 2021

For the record: discussed and decided to merge as-is and the leftover TODOs will be handled in the follow-up. Thank you @skshetry 🙏

@efiop efiop merged commit ed2a0b4 into treeverse:master Jun 4, 2021
@skshetry skshetry deleted the webdav4 branch June 4, 2021 14:06
@efiop efiop added the enhancement Enhances DVC label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances DVC fs: webdav Related to the Webdav filesystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants