webdav4: migrate to new library #6099
Merged
Merged
Conversation
Contributor
@skshetry x100 faster? 😮 If so, could you elaborate on key differences that allowed you to achieve that? |
Collaborator
Author
This has been recently fixed, but not released so far. Just a humblebrag. 😄 |
df4ceec to
98a8532
Compare
Contributor
|
For the record: discussed and decided to merge as-is and the leftover TODOs will be handled in the follow-up. Thank you @skshetry 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the fetch speed comparison between the two libraries:
webdavclient3
webdav4
TODO:
Additionally, while we are at it, it'd be great to support:
verifycerts (see http/webdav: support specifying custom certs inssl_verify#6142)Thank you for the contribution - we'll try to review it as soon as possible. 🙏