[WIP] plots: html_template -> html#6221
Conversation
pared
requested review from
isidentical and
jorgeorpinel
and removed request for
isidentical
| Optional("parametrization", default=True): Bool | ||
| }, | ||
| "plots": {"html_template": str}, | ||
| "plots": {"html": str}, |
There was a problem hiding this comment.
Can it compatible with the old schema? Some users might have an old version in their workspace.
There was a problem hiding this comment.
This is true, but the feature is relatively new and I think there is more harm in leaving html_template because users might associate template with vega templates and not understand what it actually is.
There was a problem hiding this comment.
Can we adopt the old version, and transfer it to new ones? Or at least give some friendly messages when it happens.
There was a problem hiding this comment.
This feature was only introduced in the last minor version or so, and it was specifically developed for the Studio team, so I wouldn't expect many (probably any) other people are using it. Feel free to support both or whatever you think is best, but I don't think this is a breaking change worth worrying about.
There was a problem hiding this comment.
AFAIK @mnrozhkov is the person that needs to know about this change, also one user on discord. I will try to reach out to this user.
There was a problem hiding this comment.
Studio guys will complain about problems with this, we should not break an already released schema. We have to keep older name, but we could introduce an alias.
There was a problem hiding this comment.
My mistake, I didn't think it would be a big deal for studio.
There was a problem hiding this comment.
Related feedback, for the record: #5694 (review) (for the alias)
|
@jorgeorpinel could you take a look if description change seems allright? |
| ) | ||
| parser.add_argument( | ||
| "--html-template", | ||
| "--html", |
There was a problem hiding this comment.
This is backwards incompatible, right? Can we keep an alias or something?
| "--html", | ||
| default=None, | ||
| help="Custom HTML template for VEGA visualization.", | ||
| help="Custom HTML for VEGA visualization.", |
There was a problem hiding this comment.
| help="Custom HTML for VEGA visualization.", | |
| help="File with custom HTML container for DVC plots.", |
efiop
changed the title
|
@pared What's the plan with this PR? |
efiop
added
the
awaiting response
|
Seems like there are not too many reports of user confusion. I think we can close for now and get back to it if we actually get any requests for it. |
5 participants
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Adressing #5694 (review)