plots: Use URI for --open. #6845
Merged
Merged
Conversation
Contributor
Author
Contributor
pared
suggested changes
Oct 21, 2021
pared
approved these changes
Oct 21, 2021
pared
approved these changes
Oct 25, 2021
We were previously using relpath in *all* cases, mainly to support WSL but relpath doesn't work on macOS. Added a check for using relpath *only* for WSL. Fixes #6092
daavoo
force-pushed
the
plots-show-open-url
branch
from
f41ba76 to
ed59d7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6092