dvc: get rid of path_info #6946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
path-info-xxx
branch
3 times, most recently
from
ea9384e to
284e271
Compare
efiop
added a commit
to treeverse/dvc-bench
that referenced
this pull request
Nov 9, 2021
dvc.path_info is getting removed in treeverse/dvc#6946 Our fixtures should not depend on dvc at all, which will be fixed in the future.
Intermediate PR in removing path_info from our code base. It is completely removed from the main codebase and is still being used in tests, which will be migrated in the followups. For fs-specific simple path manipulation, we've introduced `fs.path` helper (similar to `os.path`). Fixes #6774
efiop
added a commit
to efiop/dvc
that referenced
this pull request
Nov 10, 2021
fs.path is meant to be lightweight, and we should try to avoid using os.path. Leftover from treeverse#6946
efiop
added a commit
that referenced
this pull request
Nov 10, 2021
fs.path is meant to be lightweight, and we should try to avoid using os.path. Leftover from #6946
21 tasks
daavoo
added a commit
that referenced
this pull request
Apr 11, 2022
Match behavior previous to #6946
efiop
pushed a commit
that referenced
this pull request
Apr 19, 2022
Match behavior previous to #6946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6918
Intermediate change to rip path_info out of code base. We've
tried to gradually remove path_info in smaller PRs, but unfortunately,
it is stuck so deep everywhere, that it is was not possible. So here
we are trying to rip it all out at once, which will clearly need some
grace period to smooth up the rough edges.
It is completely removed from the main codebase and is still
being used in tests, which will be migrated in the follow-ups.
For fs-specific simple path manipulation, we've introduced
fs.pathhelper (similar toos.path).Fixes #6774