exp remove: rename --all-commits flag add a new rev flag and unify the collection of revs (#7155)

[karajan1001]

fix: #7155

in exp remove

1. rename flags -A/--all-commits
2. add two new flags rev and num
3. unify the revision collection
4. add unit and func tests for them

• ❗ I have followed the Contributing to DVC checklist.

• 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

wait for #7245

[karajan1001]

@dberenbaum
One problem here, in previous --all only affect on committed exps while --queue affect only on queued ones.
But for my current implements dvc exp remove --rev master will delete all of the exps whose baseline is master.
I guess it is better to unify their behaviours here?

[dberenbaum]

Should an error be thrown for dvc exp remove with no arguments, similar to what we do for dvc exp gc?

[dberenbaum]

One problem here, in previous --all only affect on committed exps while --queue affect only on queued ones.
But for my current implements dvc exp remove --rev master will delete all of the exps whose baseline is master.
I guess it is better to unify their behaviours here?

Are dvc exp show and dvc exp run the only other commands that use the queue? I think either of these behaviors is acceptable:

• Remove queued experiments from the specified revisions only when --queue is added. So dvc exp remove --rev master -n 2 should not drop any queued experiments, but dvc exp remove --rev master --queue -n 2 should remove queued experiments from master and the prior commit. dvc exp remove -A --queue should remove all queued experiments.
• Keep --queue separate and not interact with any other flags. So dvc exp remove --rev master should not drop any queued experiments, and dvc exp remove --queue should drop queued experiments from all commits.

@pmrowla Any thoughts as you work through queuing/tasks?

Note that the behavior currently seems pretty inconsistent with respect to queued experiments:

$ dvc exp show -n 2
 ────────────────────────────────────────────────────────────────────────────────────────
  Experiment                  Created        State    avg_prec   roc_auc   prepare.split
 ────────────────────────────────────────────────────────────────────────────────────────
  workspace                   -              -         0.60724   0.96022   0.2
  master                      12:55 PM       -         0.60724   0.96022   0.2
  ├── 79d0145                 01:03 PM       Queued          -         -   0.2
  random-forest-experiments   May 29, 2021   -         0.60405    0.9608   0.2
 ────────────────────────────────────────────────────────────────────────────────────────
$ dvc exp remove -A
$ dvc exp show -n 2
 ────────────────────────────────────────────────────────────────────────────────────────
  Experiment                  Created        State    avg_prec   roc_auc   prepare.split
 ────────────────────────────────────────────────────────────────────────────────────────
  workspace                   -              -         0.60724   0.96022   0.2
  master                      12:55 PM       -         0.60724   0.96022   0.2
  ├── 79d0145                 01:03 PM       Queued          -         -   0.2
  random-forest-experiments   May 29, 2021   -         0.60405    0.9608   0.2
 ────────────────────────────────────────────────────────────────────────────────────────
$ dvc exp remove -n 2
$ dvc exp show -n 2
 ────────────────────────────────────────────────────────────────────────────────────────
  Experiment                  Created        State    avg_prec   roc_auc   prepare.split
 ────────────────────────────────────────────────────────────────────────────────────────
  workspace                   -              -         0.60724   0.96022   0.2
  master                      12:55 PM       -         0.60724   0.96022   0.2
  ├── 79d0145                 01:03 PM       Queued          -         -   0.2
  random-forest-experiments   May 29, 2021   -         0.60405    0.9608   0.2
 ────────────────────────────────────────────────────────────────────────────────────────
$ dvc exp remove --rev HEAD -n 2
 ────────────────────────────────────────────────────────────────────────────────────────
  Experiment                     Created        avg_prec   roc_auc   prepare.split   prep
 ────────────────────────────────────────────────────────────────────────────────────────
  workspace                      -               0.60724   0.96022   0.2             2017
  master                         12:55 PM        0.60724   0.96022   0.2             2017
  11-random-forest-experiments   May 29, 2021    0.60405    0.9608   0.2             2017
 ────────────────────────────────────────────────────────────────────────────────────────

[pmrowla]

Keep --queue separate and not interact with any other flags. So dvc exp remove --rev master should not drop any queued experiments, and dvc exp remove --queue should drop queued experiments from all commits

I think we should just go with this for now. I think eventually exp remove should only affect "finished" (whether successful or failed) experiments, and "removing not-yet-run experiments from the queue" will be done by a separate command.

[jorgeorpinel]

UI strings ✅ thanks