Skip to content

add: Update help of --jobs #7297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daavoo merged 1 commit into from
Jan 24, 2022
Merged

add: Update help of --jobs #7297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dvc/commands/add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ def add_parser(subparsers, parent_parser):
"--jobs",
type=int,
help=(
"Number of jobs to run simultaneously. "
"Only used along with '--to-remote'. "
"Number of jobs to run simultaneously "
"when pushing data to remote."
"The default value is 4 * cpu_count(). "
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to double check: is it a correct default value? (I thought it was something like min(4, 4 * cpu_count())? (which we should also update I think)

Copy link
Copy Markdown
Contributor Author

@daavoo daavoo Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the current default: https://github.com/iterative/dvc/blob/73fee513b955f1b44542a450318ad42eec850add/dvc/fs/base.py#L36

Do you mean that we should increase the number?

Copy link
Copy Markdown
Contributor

@shcheklein shcheklein Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I wanted to double check if it's correct or not - that's it

I always forget which one of those two lines (https://github.com/iterative/dvc/blob/73fee513b955f1b44542a450318ad42eec850add/dvc/fs/base.py#L38) apply to what part.

I would may be check if some file systems override it. Just in case.

Copy link
Copy Markdown
Contributor

@pared pared Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HASH_JOBS is for calculating checksums and can be overridden with core.checksum_jobs.
add jobs refer to to_remote functionality.

Copy link
Copy Markdown
Contributor Author

@daavoo daavoo Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would may be check if some file systems override it. Just in case.

Currently, both _JOBS and HASH_JOBS are never overwritten by any file system.

"For SSH remotes, the default is 4. "
),
Expand Down