exp show: show exp when checkpoint is running(#7329)#7349
Conversation
pmrowla
left a comment
There was a problem hiding this comment.
So the actual cause of this bug is that we don't handle fixing HEAD in iter_revs:
I think what we should really do for this is to make dvc.scm.resolve_rev() use fix_exp_head, and get rid of all of the other calls to fix_exp_head from elsewhere in DVC, otherwise we will probably keep running into this type of bug in the future.
and then we can just have one test for scm.resolve_rev() that does the same thing as:
At some point what we really want is to make scm.resolve_rev() use fix_exp_head, and get rid of all of the other fix_exp_head calls everywhere else in DVC,
|
Currently, And besides this, I don't know if there are any conditions that we need to resolve the current temp local |
This does not belong in The main issue with keeping
In the event that we need the local head, we can just use |
|
OK I would suggest renaming it here to make them more clarified. |
fix: treeverse#7329 In a previous PR, we introduce a bug which use `HEAD` as the workspace commit, while if there is a checkpoint is running, the `HEAD` is actually changing all the time, we should use `refs/exps/exec/EXEC_BASELINE` instead. 1. add `fix_exp_head` transfer in `dvc/scm.py::resolve_rev` 2. remove fix_exp_head from `diff`, `metrics diff`, `params diff` and `plots diff` 3. modify a functional test to simulate the running conditions
Fixes #7329
In a previous PR, we introduce a bug which use
HEADas the workspacecommit, while if there is a checkpoint is running, the
HEADisactually changing all the time, we should use
refs/exps/exec/EXEC_BASELINEinstead.A test is needed for this PR.
HEADinexp showwithfix_exp_head.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏