fs.callbacks: simplify, ensure None does not break them, lazy richcallbacks#7722
Merged
Conversation
8ac73b5 to
5ed3d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7704.
call()modifies the progress bars now. Progress bars now use thevalue/sizefromfsspec.Callbackinstead of using their own state.Nonevalue inrelative_update/absolute_updatedoes not break callbacks. This means that now we can guarantee thatvaluewill always be int. This is useful for filesystems that are not very compliant.Note that
sizecan beNone, this has to be handled in respective callbacks,TqdmCallbacknow usesupdate_towhich handles them,RichCallbackalso handles those well.