studio: handle revision errors when posting#9137
Merged
Merged
Conversation
Contributor
Author
|
Related: #8986 |
daavoo
approved these changes
Mar 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9137 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 456 456
Lines 36821 36824 +3
Branches 5313 5314 +1
=======================================
+ Hits 34212 34215 +3
Misses 2085 2085
Partials 524 524
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3b35b1b to
d474ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: I found this when testing out a treeverse/dvclive#464 in a repo with overlapping outputs (tracking the model as both a stage output and in a .dvc file).
Before this PR:
After this PR:
This still isn't a good UX, but at least now I can see a somewhat more useful error.