repro: pull all missing files#9395
Conversation
b8f7850 to
3b783b8
Compare
3b783b8 to
67ff3e1
Compare
|
@dberenbaum ping |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9395 +/- ##
==========================================
+ Coverage 91.59% 91.60% +0.01%
==========================================
Files 487 487
Lines 37822 37855 +33
Branches 5440 5443 +3
==========================================
+ Hits 34642 34677 +35
+ Misses 2623 2622 -1
+ Partials 557 556 -1
☔ View full report in Codecov by Sentry. |
dberenbaum
left a comment
There was a problem hiding this comment.
Haven't tested, but assuming it's the same as #9375, LGTM
| if kwargs.get("pull", False): | ||
| logger.debug("Pulling run cache") | ||
| self.stage_cache.pull(None) |
There was a problem hiding this comment.
This might take awhile, but I guess this is acceptable with --pull. But still hope to finally get to converting run-cache to dvc-objects to that this operation could be efficient.
|
I am against this PR as I have written here.
|
So, if I move the pull to inside
Do you have any ideas for a simpler interface? Putting it inside the stage and using |
Side question. Do we have any tests for this? |
Closes #4742
Point 1 in #9375 (comment)