Removes noisy and misleading print() in init#247
Conversation
daavoo
left a comment
There was a problem hiding this comment.
I'm ok with this.
If I remember correctly, we added this to maintain parity with the previous behavior when the HTML was generated by DVC, where DVC will print this message at the beginning of running the stage.
@dberenbaum WDYT?
003a464 to
36e17cf
Compare
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 90.15% 90.11% -0.05%
==========================================
Files 20 20
Lines 691 688 -3
==========================================
- Hits 623 620 -3
Misses 68 68
Continue to review full report at Codecov.
|
IMO the primary scenario for dvclive is seeing a live-updated report of the model being trained. We have already made some compromises about the ease of seeing this report by not opening it by default (see the discussion in #243 (comment)). If we don't provide the user with the report path, it will be harder for users to even know the report is being generated and to know the path of the report. Do you have an alternate suggestion?
These seem like implementation details/bugs rather than reasons to remove the feature. Do you still think it should be removed if these are resolved @shcheklein? |
At least have a clear way to silence it? Usually it's fine for libs to have loggers, but there is a path to toggle them on / off. The cleanest way to communicate back, would be probably some callback or some env variable that any consumer can read and decide what has to be printed.
If bugs are solved I don't feel it's that critical to remove this. You decide folks, I can probably see if I can rework this to solve the bug itself, not removing the whole thing. |
Added logger and env var in #250
The message is only logged if However, showing the message when we know for a fact that report has been created is tricky as it can mess up with the ML frameworks progress bars, that's why we moved the message on DVC from the end of |
👍
Change the message then at least to be more explicit? "Report path (if generated): .... See more on report here ...."? (btw, feel free to close this one) |
|
Looks even uglier now, folks :(
|
printsReport will be saved atis printed in some cases but actual report is not created (e.g. if we use dvclive only as a tool to write plots, metrics, images)❗ I have followed the Contributing to DVCLive guide.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏