Update reqs, fix TF bug #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
added
bug
jorgeorpinel
suggested changes
Nov 1, 2019
jorgeorpinel
reviewed
Nov 1, 2019
jorgeorpinel
approved these changes
Nov 1, 2019
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Works for me. Nice addition about tqdm!
shcheklein
approved these changes
Nov 1, 2019
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Haven't tested but looks great. @jorgeorpinel how about speed this time?
Contributor
|
Just pending:
I'll address this myself 🙂 |
Contributor
|
@jorgeorpinel feel free to merge it you feel it's done! @casperdcl good stuff! thanks! |
Contributor
Still a few minutes, maybe under 10 though. Drained 4% of my battery too haha. Seems reasonable to me. The tutorial runs this 3 times though. |
jorgeorpinel
added a commit
to treeverse/dvc.org
that referenced
this pull request
Nov 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
tensorflow==2scipydependencyCSVLoggertqdmREADME.mdlink to documentationTODO
After merge, update https://dvc.org/doc/tutorials/versioning to use
metrics.csvrather thanmetrics.json