Skip to content

Add DVCLIVE_OPEN env var#1625

Merged
mattseddon merged 3 commits into
mainfrom
add-dvclive-open-env-var
May 1, 2022
Merged

Add DVCLIVE_OPEN env var#1625
mattseddon merged 3 commits into
mainfrom
add-dvclive-open-env-var

Conversation

@mattseddon
Copy link
Copy Markdown
Contributor

@mattseddon mattseddon commented Apr 28, 2022

Uses env var provided by treeverse/dvclive#243.

I tested:

  1. setting env var to 'true' changes the behaviour to auto_open the html
  2. setting env var to 'false' retains the expected behaviour

We can review but will need to wait for 2.10.2 to be released before we can merge.

@mattseddon mattseddon added the product PR that affects product label Apr 28, 2022
@mattseddon mattseddon self-assigned this Apr 28, 2022
@mattseddon mattseddon added the A: integration Area: DVC integration layer label Apr 28, 2022
@mattseddon mattseddon marked this pull request as ready for review April 28, 2022 01:19
@mattseddon mattseddon enabled auto-merge (squash) May 1, 2022 22:48
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit f813718 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit daea470 into main May 1, 2022
@mattseddon mattseddon deleted the add-dvclive-open-env-var branch May 1, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: integration Area: DVC integration layer product PR that affects product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants