Fix filter bypass leading to XSS (#362)#434
Merged
nicholasserra merged 1 commit intotrentm:masterfrom Jul 17, 2022
Merged
Conversation
Collaborator
|
Thanks, will take a close look at this soon. |
Collaborator
|
@terjanq wondering if you'd peek this fix, see if you notice any issues with it |
Collaborator
|
I wasn't able to reproduce the first issue anymore at all. But this looks fine to merge anyway. |
|
Hey @nicholasserra, |
|
Can you tag a release with this fix? Thanks! |
Collaborator
|
@SuperSandro2000 2.4.4 has been released with this and another xss fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @terjanq:
I was able to reproduce this issue.
The proposed change ignores whitespace between the tag name and the
.+and from my tests this seems to do the trick.However, I will admit that I'm not a security guy so it's possible that this change has it's own issues.
Furthermore, I was unable to reproduce the second example given in #362, so that might already have been fixed.