Fix emacs one-liner file vars having surrounding whitespace stripped#460
Merged
nicholasserra merged 2 commits intotrentm:masterfrom Jul 21, 2022
Merged
Fix emacs one-liner file vars having surrounding whitespace stripped#460nicholasserra merged 2 commits intotrentm:masterfrom
nicholasserra merged 2 commits intotrentm:masterfrom
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #454, I introduced a bug with emacs one-liner file variables that caused surrounding whitespace to be removed from them.
This issue is demonstrated by the following markdown:
The emacs one-liner would be matched and substituted by
_emacs_vars_oneliner_sub, which would not replace the\n\nbetween the markdown metadata closing fence and the one-liner, resulting in the following text:Which would later go on to cause an
IndexErrorin_extract_metadata.This PR fixes this issue by extracting the leading and tailing whitespace from the matched emacs one-liner and making sure they are added back to the one-liner after it has been wrapped in HTML comment tags