Fix pygments block matching#462
Merged
nicholasserra merged 4 commits intotrentm:masterfrom Aug 16, 2022
Merged
Conversation
Collaborator
|
The tests that were modified, they're all just html formatting changes right? Wanna make sure I didn't miss anything. |
Contributor
Author
|
Yes, correct! :) |
21fc597 to
eb1938b
Compare
eb1938b to
f1634cc
Compare
Contributor
Author
|
I've rebased this onto master and also added a fix for mitmproxy/pdoc#429, which depends on the formatting changes here. 😃 |
Collaborator
|
LGTM thank you for the work on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for mitmproxy/pdoc#421. Consider the following Markdown:
markdown2 would previously first convert the fenced code block to
<div class="codehilite">...</div>, and then, in_hash_html_blocks, match from the first pygments<div class="codehilite">to the final</div>at the end of the file1. Everything in between (such as# Section 2) would be skipped.I also considered to directly hash the pygments output instead (mhils@9622c05), but that changes
<p>paragraph wrapping and would be more of a breaking change. So I think this approach is preferrable.Footnotes
_strict_tag_block_redoes this before_liberal_tag_block_rematches. ↩