Fix hashing nested HTML blocks#483
Merged
nicholasserra merged 3 commits intotrentm:masterfrom Nov 2, 2022
Merged
Conversation
Nested HTML blocks of the same type (eg: nested div's) would be hashed incorrectly as the `_strict_block_tag_re` would match the FIRST closing tag and ignore any subsequent closing tags. This commit fixes this behaviour by iterating over all the lines in a given text, manually tallying up the number of opening/closing tags and then hashing the relevant block
Collaborator
|
LGTM thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #481 by fixing
_hash_html_blocksmatching the wrong HTML closing tag when hashing HTML blocks.An example like this:
Would end up with the final closing
</div>tag wrapped in<p>tags as the_strict_block_tag_refailed to match against the whole<div>block correctly.This fix solves this issue by iterating over the given text and manually tallying up the number of opening and closing
<div>tags and then hashing the relevant block.