Skip to content

Breaks improvements and code simplification#544

Merged
nicholasserra merged 1 commit intotrentm:masterfrom
m417z:breaks-improvements
Jan 5, 2024
Merged

Breaks improvements and code simplification#544
nicholasserra merged 1 commit intotrentm:masterfrom
m417z:breaks-improvements

Conversation

@m417z
Copy link
Copy Markdown
Contributor

@m417z m417z commented Dec 9, 2023

  • Using both a newline and a backslash no longer results in two line breaks.
  • Allow to keep using trailing spaces for a line break.
  • Remove redundant trailing space before a line break.

@nicholasserra
Copy link
Copy Markdown
Collaborator

Looks like some test failures. @Crozzers if you have a sec would love your eyes on this too thanks!

* Using both a newline and a backslash no longer results in two line breaks.
* Allow to keep using trailing spaces for a line break.
* Remove redundant trailing space before a line break.
@m417z
Copy link
Copy Markdown
Contributor Author

m417z commented Dec 10, 2023

Rebased and fixed WaveDrom tests.

@Crozzers
Copy link
Copy Markdown
Contributor

LGTM. The removal of if 'breaks' in self.extras threw me for a bit but that looks to be covered in the else clause

@nicholasserra nicholasserra merged commit 1c7902b into trentm:master Jan 5, 2024
@nicholasserra
Copy link
Copy Markdown
Collaborator

Thanks!

@m417z m417z deleted the breaks-improvements branch January 6, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants