Fix incorrect parsing of links after square brackets (#552)#556
Merged
nicholasserra merged 2 commits intotrentm:masterfrom Dec 17, 2023
Merged
Fix incorrect parsing of links after square brackets (#552)#556nicholasserra merged 2 commits intotrentm:masterfrom
nicholasserra merged 2 commits intotrentm:masterfrom
Conversation
Links parser would identify the first square brackets as invalid link and then continue from after the entire link, which skipped the valid link right next to the brackets
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #552.
The issue was with links following square brackets, eg:
[text][link](google.com). The link parser would hit[text][link]and correctly identify that this isn't a valid link. It would then set the current position counter to the end of the entire "match", which included the section containing the valid link.I've changed it to set the current position to directly after the first square brackets, so that it picks up on the link right after