Fix markdown-in-html not always splitting HTML tags into separate lines (#558)#560
Merged
nicholasserra merged 3 commits intotrentm:masterfrom Dec 26, 2023
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #558, which is a continuation from #546.
The issue is regarding
markdown-in-htmltags that are not on their own line. This issue was partially fixed in #547, but the solution was gated behind a check forif len(lines) < 3.This check was based on the assumption that the snippets would look like this:
This assumption completely breaks down for longer snippets, leading to HTML tags not being properly split from the surrounding markdown.
This PR fixes this by always attempting to split the HTML tags into separate lines