Added filter for the tabs array on the tools page#212
Conversation
Member
|
Everything looks good. I just renamed the filter. |
ghost
deleted the
ghost
mentioned this pull request
jnorell
pushed a commit
to jnorell/GDPR
that referenced
this pull request
Nov 2, 2018
* Added filter for the tabs array on the tools page for hiding and adding pages * Renaming filter
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developers can use this filter to remove (hide) or add pages on the Tools page.
Use case: Company has a very specific data breach protocol used company wide for multiple sites. Hiding the Data Breach page will eliminate any confusion for site managers and prevent them from accidentally not following protocol.
I think I'm also going to work on an action to add content to a new tools page.
This is my first time contributing to a public repo with a PR so please let me know if I did anything wrong.