Require explicit Optional in type annotations #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
😿 |
matejcik
approved these changes
Nov 5, 2020
Author
|
@matejcik Would it be possible to make a PyPI release? Would be cool to have all the annotations brought out 😸 |
0racl3z
approved these changes
May 8, 2021
0racl3z
approved these changes
May 8, 2021
Contributor
|
this is now out on pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the "implicit optional" mypy feature. Type annotations relying on it are no longer PEP 484 compliant (see python/peps#689). Mypy will also turn the feature off in a future release (see python/mypy#9091).