Support extendable backup flag#46
Conversation
matejcik
left a comment
There was a problem hiding this comment.
functionality LGTM.
i added a bunch of commits fixing tiny problems. please review 706934d in particular which is the only questionable one -- it seemed cleaner to pass the full customization string into RS1024 from the outside. but I'm not attached to that solution, i'll remove that commit if you dislike it.
|
a1cb726 Updated a comment. The customization string |
|
706934d breaks generate_vectors.py, line 66: mnemonic = wordlist.mnemonic_from_indices(
indices + rs1024.create_checksum(indices, False)
) |
|
LGTM, go ahead |
Related to spec update satoshilabs/slips#1724.
Note that we need to get this merged and released in order for the firmware device tests to pass on the corresponding firmware branch https://github.com/trezor/trezor-firmware/compare/andrewkozlik/slip39.