Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

MT Ksvc per-namespace Adapter#23

Merged
tzununbekov merged 1 commit into
mainfrom
ksvc-adapter
Jul 6, 2021
Merged

MT Ksvc per-namespace Adapter#23
tzununbekov merged 1 commit into
mainfrom
ksvc-adapter

Conversation

@tzununbekov
Copy link
Copy Markdown
Member

@tzununbekov tzununbekov commented Jul 4, 2021

Routing components migrated to MT methods borrowed from Knative Sources.
Closes #20

@tzununbekov tzununbekov self-assigned this Jul 5, 2021
@tzununbekov tzununbekov marked this pull request as ready for review July 5, 2021 07:13
@tzununbekov tzununbekov changed the title Ksvc adapter MT Ksvc per-namespace Adapter Jul 5, 2021
Copy link
Copy Markdown
Member

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with comments.

I went light on all files that sounded identical to sources ones.

Comment thread pkg/adapter/common/env/env.go Outdated
Comment thread pkg/adapter/filter/adapter.go Outdated
Comment thread pkg/adapter/filter/env.go Outdated
Comment thread pkg/adapter/filter/reconciler.go
Comment thread pkg/adapter/filter/reconciler.go
@odacremolbap odacremolbap self-requested a review July 6, 2021 09:32
Copy link
Copy Markdown
Member

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delegate lifecycle of adapters to reconcilers

2 participants