This repository was archived by the owner on Oct 12, 2021. It is now read-only.
Repository renamed to "Routing"#7
Merged
Merged
Conversation
antoineco
reviewed
Apr 21, 2021
| PodName string `envconfig:"POD_NAME" required:"true"` | ||
| ContainerName string `envconfig:"CONTAINER_NAME" required:"true"` | ||
| Port int `envconfig:"FILTER_PORT" default:"8080"` | ||
| Port int `envconfig:"FILTER_PORT" default:"8080"` |
Contributor
There was a problem hiding this comment.
Just a question since this code already existed before this PR: what's the case for making this configurable?
Member
Author
There was a problem hiding this comment.
tbh, I cannot make up the real case when this may need to be changed, but at the same time cannot see anything harmful in it either. I'd say that we can leave it until the next time we change something in that part of the code.
tzununbekov
force-pushed
the
routing-rename
branch
from
7d945d5 to
dd99535
Compare
tzununbekov
force-pushed
the
routing-rename
branch
from
dd99535 to
a0cdb32
Compare
Member
Author
|
ping dear reviewers! let's finish this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter repository renamed to Routing
Related to #5