Skip to content

feat(block): improve performance for transaction packing#4756

Merged
halibobo1205 merged 1 commit intotronprotocol:developfrom
halibobo1205:feat/pack_trx_opt
Nov 30, 2022
Merged

feat(block): improve performance for transaction packing#4756
halibobo1205 merged 1 commit intotronprotocol:developfrom
halibobo1205:feat/pack_trx_opt

Conversation

@halibobo1205
Copy link
Copy Markdown
Collaborator

@halibobo1205 halibobo1205 commented Nov 1, 2022

What does this PR do?

  1. remove unused code
  2. optimize cycle operation

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205
Copy link
Copy Markdown
Collaborator Author

halibobo1205 commented Nov 15, 2022 •
edited
Loading

trace generateBlock

---[781.371363ms] org.tron.core.db.Manager:generateBlock()
        +---[0.45% ,total=3.54333ms,count=5126] org.tron.core.config.args.Args:getInstance() 
        +---[0.42% ,total=3.310764ms,count=5126] org.tron.common.parameter.CommonParameter:isOpenTransactionSort() 
        +---[0.52% ,total=4.030139ms,count=5125] org.tron.core.capsule.TransactionCapsule:getSerializedSize() 
        +---[0.44% ,total=3.421337ms,count=5125] org.tron.core.capsule.TransactionCapsule:getInstance() 
        +---[0.42% ,total=3.281247ms,count=5125] org.tron.core.capsule.TransactionCapsule:getInstance()

@halibobo1205 halibobo1205 force-pushed the feat/pack_trx_opt branch 2 times, most recently from e615370 to a66493b Compare November 16, 2022 08:07
@halibobo1205 halibobo1205 marked this pull request as ready for review November 24, 2022 09:20
@halibobo1205
feat(block): improve performance for transaction packing
217469d 
  1. remove unused code
  2. optimize cycle operation
hosein6666
hosein6666 reviewed Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown

@hosein6666 hosein6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoseing061@gmail.com

@hosein6666
Copy link
Copy Markdown

hosein6666 commented Nov 29, 2022

Rfuy6

@halibobo1205 halibobo1205 merged commit 5c4e491 into tronprotocol:develop Nov 30, 2022
@ethan1844 ethan1844 mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@hosein6666 hosein6666 hosein6666 left review comments

@zhang0125 zhang0125 zhang0125 approved these changes

@tomatoishealthy tomatoishealthy tomatoishealthy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@halibobo1205 @hosein6666 @zhang0125 @tomatoishealthy