Skip to content

feat(api): optimize api compatibility#5408

Merged
halibobo1205 merged 2 commits intotronprotocol:developfrom
lxcmyf:feature/optimize_api_parameters
Aug 22, 2023
Merged

feat(api): optimize api compatibility#5408
halibobo1205 merged 2 commits intotronprotocol:developfrom
lxcmyf:feature/optimize_api_parameters

Conversation

@lxcmyf
Copy link
Copy Markdown
Collaborator

@lxcmyf lxcmyf commented Aug 9, 2023

What does this PR do?
optimize api compatibility, close #5398

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 9, 2023
@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch 2 times, most recently from 5dcb204 to 9fa06c6 Compare August 9, 2023 16:47
@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch 3 times, most recently from ae280c5 to dcca2c1 Compare August 15, 2023 06:42
@halibobo1205
Copy link
Copy Markdown
Collaborator

halibobo1205 commented Aug 16, 2023

@lxcmyf Please add unit test to cover all changes.

@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch from dcca2c1 to 3c850af Compare August 16, 2023 13:35
Comment thread framework/src/main/java/org/tron/core/services/http/GetAccountServlet.java Outdated
Comment thread chainbase/src/main/java/org/tron/core/db/ResourceProcessor.java
Comment thread framework/src/main/java/org/tron/core/services/http/Util.java
Comment thread framework/src/main/java/org/tron/core/services/http/Util.java Outdated
Comment thread framework/src/main/java/org/tron/core/services/http/Util.java Outdated
Comment thread framework/src/main/java/org/tron/core/services/http/PostParams.java Outdated
Comment thread framework/src/main/java/org/tron/core/services/http/GetAccountServlet.java Outdated
@halibobo1205
Copy link
Copy Markdown
Collaborator

@lxcmyf Please add unit test to cover all changes.

It is still recommended to add all the test.

@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch 3 times, most recently from 1856965 to d0aa39c Compare August 17, 2023 15:40
@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch from d0aa39c to 5551012 Compare August 18, 2023 05:24
Copy link
Copy Markdown
Collaborator

@halibobo1205 halibobo1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halibobo1205 halibobo1205 merged commit ac90c45 into tronprotocol:develop Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimization for certain API Interfaces

3 participants