Skip to content

feat(test): improve unit test coverage#5988

Merged
lvs007 merged 1 commit intotronprotocol:developfrom
lxcmyf:feature/improve_coverage
Oct 9, 2024
Merged

feat(test): improve unit test coverage#5988
lvs007 merged 1 commit intotronprotocol:developfrom
lxcmyf:feature/improve_coverage

Conversation

@lxcmyf
Copy link
Copy Markdown
Collaborator

@lxcmyf lxcmyf commented Sep 4, 2024 •
edited
Loading

What does this PR do?
improve unit test coverage, close #5434
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lxcmyf lxcmyf force-pushed the feature/improve_coverage branch 3 times, most recently from d40da4a to b910d33 Compare September 11, 2024 09:35
@lxcmyf lxcmyf force-pushed the feature/improve_coverage branch 2 times, most recently from 33736f8 to 27235e8 Compare September 13, 2024 02:03
tomatoishealthy
tomatoishealthy reviewed Sep 19, 2024
View reviewed changes
Comment thread framework/src/test/java/org/tron/common/EntityTest.java Outdated
Comment thread framework/src/test/java/org/tron/common/ParameterTest.java
Comment thread framework/src/test/java/org/tron/common/cache/TronCacheTest.java Outdated
Comment thread framework/src/test/java/org/tron/common/logsfilter/capsule/BlockLogTriggerCapsuleTest.java Outdated
Comment thread framework/src/test/java/org/tron/common/logsfilter/capsule/ContractLogTriggerCapsuleTest.java Outdated
Comment thread framework/src/test/java/org/tron/common/logsfilter/capsule/ContractTriggerCapsuleTest.java Outdated
Comment thread framework/src/test/java/org/tron/common/runtime/vm/BatchSendTest.java Outdated
Comment thread framework/src/test/java/org/tron/common/runtime/vm/DataWordTest.java Outdated
@tomatoishealthy
Copy link
Copy Markdown
Contributor

tomatoishealthy commented Sep 19, 2024

BTW, given that this PR adds a lot of tests, how much impact will the newly added tests have on the CI test time?

@lxcmyf
Copy link
Copy Markdown
Collaborator Author

lxcmyf commented Sep 19, 2024 •
edited
Loading

@tomatoishealthy
This is a comparison of the time consumption with the previously merged PR. It seems that there should be almost no difference.
image
image

@lxcmyf lxcmyf force-pushed the feature/improve_coverage branch from 27235e8 to f9a86f7 Compare September 19, 2024 07:08
@lvs007 lvs007 merged commit f7ecfc3 into tronprotocol:develop Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuny0707 kuny0707 kuny0707 approved these changes

+2 more reviewers

@lvs007 lvs007 lvs007 approved these changes

@tomatoishealthy tomatoishealthy tomatoishealthy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve code coverage to 70%

4 participants

@lxcmyf @tomatoishealthy @kuny0707 @lvs007