-
Notifications
You must be signed in to change notification settings - Fork 54
Enables bitcode support for TLSphinx #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ld scripts tailored specifically for TLSphinx
|
|
||
| --- | ||
| ## Manual Compilation | ||
| If possible please try automatic compilation when possible, manual compilation is not for the feint of heart yet it might help in scenarios where you want to build CMU Sphinx Base and Pocket Sphinx from their respective master branches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo: feint should be faint
|
Thank you very much for this PR :) Really apreciaste your work. I found something strange when checking the binaries here. There seems not to have the bit code included in the libraries. I'm running this tests (I test all the fat binaries, here only mention The calls to Also the date of the fat library for pocketsphinx doesn't match the date for all the architectures here, maybe you forgot to rebuild the fat lib? Thanks again! |
|
Let me check what happened with the Fat one.... |
|
Ok, this is what I found... otool does not work recursively, that is... it will look for symbols in the fat binary itself but not in any embedded static libs thus it won't show bitcode information. You'll get this output The reason i386 and x86_64 does not show bitcode information is because it is till not supported for macOS/App Store apps. My guess is that ebcutil shows no bitcode information on bio.o because it is testing the one in either i386 and x86_64 and is correctly stating that those do not have bitcode support. The case for pocketsphinx's fat binary was that my script did not copied it due to a bug (actually a missing cp command), I'll be committing a fix shortly and also a new set binaries. |
|
According to ebcutil...
Which matches with my previous comment. |
…a fat binary into Sphinx/lib/pocketsphinx/libpocketsphinx.a
|
Awesome! Thanks |
|
My pleasure |
Should fix #36
Provides sphinx binaries with bitcode support and also allows bitcode compilation for TLSphinx.
Includes a few utility scripts to rebuild sphinxbase and pocketsphinx when new versions are released by CMU's team.
Binaries provided are still pre5alpha, but including new releases should be a lot easier in the future.