Added functionality to allow returning wrapped classes from member functions#13
Open
hammonda wants to merge 6 commits intotsa:masterfrom
Open
Added functionality to allow returning wrapped classes from member functions#13hammonda wants to merge 6 commits intotsa:masterfrom
hammonda wants to merge 6 commits intotsa:masterfrom
Conversation
…rapped c++ classes.
Owner
|
Hi sorry for the delay. I'll look at this very soon! |
Owner
|
Hi, please see my comments on the individual commits. I will re-review after you've fixed those issues. You won't have to wait so long sorry about the delay! |
Author
|
Sorry about the reformatting ... |
Owner
|
No problem, you can reformat with a second patch if you want I also prefer 2 characters now! David Hammond notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/hammonda/NodeAddons/tree/master/vu8_addon_1 for an example.