Preparation for v10 of RFC8776-bis#262
Merged
italobusi merged 12 commits intotsaad-dev:masterfrom Feb 22, 2024
Merged
Conversation
italobusi
changed the title
Updated te-types and te-packet-types as agreed during the call on February 9, 2024
- Added description of the changes in previous updates; - Added ordered-by statement to tiebreaker list in generic-path-optimization grouping: fix tsaad-dev#266
tsaad-dev
reviewed
Feb 21, 2024
| reference | ||
| "RFC 7471: OSPF Traffic Engineering (TE) Metric Extensions"; | ||
| } | ||
| identity link-metric-te { |
Collaborator
Author
There was a problem hiding this comment.
It's a convention I have seen elsewhere to make the derived identities look like as being nested after the base identity
I found this convention quite convenient when looking for the next base identity
tsaad-dev
reviewed
Feb 21, 2024
| Version 2 | ||
| RFC 7471: OSPF Traffic Engineering (TE) Metric Extensions"; | ||
| } | ||
| identity link-metric-igp { |
Owner
There was a problem hiding this comment.
can you check if right alignment (4 spaces?)
Collaborator
Author
There was a problem hiding this comment.
tsaad-dev
approved these changes
Feb 21, 2024
xufengliu
approved these changes
Feb 21, 2024
italobusi
added a commit
that referenced
this pull request
Feb 22, 2024
This reverts commit 1086a5f.
italobusi
added a commit
that referenced
this pull request
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.