Skip to content

feature: enable rotate service secret#35

Merged
tschaefer merged 1 commit intomainfrom
tschaefer/feature/rotate-secret
Feb 13, 2026
Merged

feature: enable rotate service secret#35
tschaefer merged 1 commit intomainfrom
tschaefer/feature/rotate-secret

Conversation

@tschaefer
Copy link
Owner

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a new feature to rotate the service secret for deployed Finch services. The implementation adds a new CLI command finchctl service rotate-secret that generates a new random 32-byte secret, updates the finch.json configuration file, and restarts the finch service to apply the change. Additionally, the PR removes the version field from the finch.json configuration template.

Changes:

  • Added RotateSecret method and supporting infrastructure to enable rotating the service secret
  • Removed version field from finch.json template
  • Updated version from 1.3.0 to 1.7.0 in deployment configuration

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
internal/service/rotate_secret.go Implements the core secret rotation logic: reads existing config, generates new 32-byte random secret, updates config file, and restarts finch service
internal/service/service.go Adds RotateSecret public method with requirements validation and error handling
internal/service/errors.go Defines RotateServiceSecretError type following existing error pattern
cmd/service/rotate_secret.go Implements CLI command with standard flags (format, dry-run) and argument parsing
cmd/service/service.go Registers the new rotate-secret subcommand
internal/service/service_test.go Adds test coverage for the rotate secret functionality
internal/service/assets/finch.json.tmpl Removes version field from JSON template
internal/service/deploy.go Updates version to 1.7.0 (though version field is removed from template)

@tschaefer tschaefer force-pushed the tschaefer/feature/rotate-secret branch from 0ea8009 to 766db00 Compare February 12, 2026 21:53
@tschaefer tschaefer force-pushed the tschaefer/feature/rotate-secret branch from 766db00 to add042e Compare February 12, 2026 22:05
@tschaefer tschaefer marked this pull request as ready for review February 13, 2026 10:46
@tschaefer tschaefer merged commit 7c7ed03 into main Feb 13, 2026
2 checks passed
@tschaefer tschaefer deleted the tschaefer/feature/rotate-secret branch February 13, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments