Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a new feature to rotate the service secret for deployed Finch services. The implementation adds a new CLI command finchctl service rotate-secret that generates a new random 32-byte secret, updates the finch.json configuration file, and restarts the finch service to apply the change. Additionally, the PR removes the version field from the finch.json configuration template.
Changes:
- Added RotateSecret method and supporting infrastructure to enable rotating the service secret
- Removed version field from finch.json template
- Updated version from 1.3.0 to 1.7.0 in deployment configuration
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/service/rotate_secret.go | Implements the core secret rotation logic: reads existing config, generates new 32-byte random secret, updates config file, and restarts finch service |
| internal/service/service.go | Adds RotateSecret public method with requirements validation and error handling |
| internal/service/errors.go | Defines RotateServiceSecretError type following existing error pattern |
| cmd/service/rotate_secret.go | Implements CLI command with standard flags (format, dry-run) and argument parsing |
| cmd/service/service.go | Registers the new rotate-secret subcommand |
| internal/service/service_test.go | Adds test coverage for the rotate secret functionality |
| internal/service/assets/finch.json.tmpl | Removes version field from JSON template |
| internal/service/deploy.go | Updates version to 1.7.0 (though version field is removed from template) |
0ea8009 to
766db00
Compare
766db00 to
add042e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.