Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for macOS and Windows agents to the Finch monitoring system. The changes enable the deployment and management of Grafana Alloy agents on macOS using launchd and add support for collecting Windows event logs.
Changes:
- Added "node" field to API messages to track agent platform type (unix/windows)
- Implemented macOS (darwin) support with launchd service management
- Added Windows event log collection via "event://" URL scheme
- Included PowerShell installer script for Windows Alloy installation
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/api/api.proto | Added "node" field to RegisterAgentRequest and GetAgentResponse messages |
| internal/api/api.pb.go | Regenerated protobuf code with node field and comment cleanup |
| internal/agent/machine.go | Removed early return that blocked macOS support |
| internal/agent/deploy.go | Added launchd service deployment and macOS-specific binary path handling |
| internal/agent/teardown.go | Added launchd service teardown for macOS |
| internal/agent/update.go | Added macOS-specific binary path and service restart logic |
| internal/agent/register.go | Added node field to registration data |
| internal/agent/describe.go | Added support for event log sources and node field display |
| internal/agent/assets/com.github.tschaefer.finch.agent.plist | New launchd service configuration file for macOS |
| contrib/install-latest-alloy.ps1 | New PowerShell script to install Alloy on Windows |
| cmd/agent/register.go | Added flags for event log collection and node type specification |
| cmd/agent/describe.go | Added display of node type and event log sources |
| cmd/completion/completion.go | Added shell completion for node type values |
| internal/service/assets/docker-compose.yaml.tmpl | Updated Finch container image tag |
| Makefile | Simplified proto generation command |
5d72e73 to
b32a6fa
Compare
b32a6fa to
3569f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.