Skip to content

add docs supporting importing JLCPCB components using RunFrame#64

Merged
seveibar merged 1 commit into
tscircuit:mainfrom
Anshgrover23:add-video
Jun 1, 2025
Merged

add docs supporting importing JLCPCB components using RunFrame#64
seveibar merged 1 commit into
tscircuit:mainfrom
Anshgrover23:add-video

Conversation

@Anshgrover23
Copy link
Copy Markdown
Contributor

@Anshgrover23 Anshgrover23 commented Jun 1, 2025

/claim #40
Fixes #40

2025-06-01.13-48-19.mp4

supporting youtube video link: https://youtu.be/tFCGAa81KUs

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2025 3:36pm

Copy link
Copy Markdown
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, Also we need to upload that video from the tscircuit channel and use that YouTube video id.

@Anshgrover23
Copy link
Copy Markdown
Contributor Author

@imrishabh18 yes, we can just remove my youtube video link from there and upload this video to tscircuit channel as i don't have perms for that, i think @seveibar can do that.

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented Jun 1, 2025

I think linking to ansh’s youtube is ok for now, and the video is good, but i do think it would be better if you then wrote the import in the index file so that the user could see that the import works and is usable

Comment thread package.json Outdated
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End users dont know what runframe is, you should explain as “from tsci dev” or “using the cli” in the doc text

@Anshgrover23
Copy link
Copy Markdown
Contributor Author

Anshgrover23 commented Jun 1, 2025

@seveibar here is the new video addressing your comment of importing into index.ts file included in video.

runframe-jlcpcb-import.mp4

check the new video in deployement.

@Anshgrover23 Anshgrover23 requested review from seveibar June 1, 2025 15:32
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ansh, this is quite good. I would have used a more complex chip though and given it the name U1. It's not really clear what you imported because it isn't a common chip AFAIK. Importing something like the PICO_W would be really good and have a complex symbol. I would also remove the other components from the design (the trace resistor and capacitor) because they're clutter than confuses the main point. Feel free to follow up if you'd like, but approving/merging because this is an improvement over the existing docs.

@seveibar seveibar merged commit 2311d92 into tscircuit:main Jun 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document importing JLCPCB components using RunFrame in the first section of "Importing from JLCPCB"

3 participants