Add missing step and layer properties to Arrow type#103
Open
mendarb wants to merge 1 commit into
Open
Conversation
The Arrow interface was missing step and layer properties that all other graphic element types (Point, Line, Rect, Circle, Polygon, Text) have. This also adds arrow handling to setStepOfAllObjects which was previously skipping arrows, and adds tests for setStepOfAllObjects. Closes tscircuit#75 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stepandlayerproperties to theArrowinterface, bringing it in line with all other graphic element types (Point,Line,InfiniteLine,Rect,Circle,Polygon,Text) which already had these propertiessetStepOfAllObjectsto handle arrows, which was previously skipping themsetStepOfAllObjectscovering all element types including arrowsCloses #75
Test plan
setStepOfAllObjectstest covers all element types including arrows🤖 Generated with Claude Code