bdb : Fix startup failures #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo's have been left off in the code. What doesn't work: - Loading external natives - Reading symbols (blocked by #99)
Member
|
@herrhotzenplotz looks good to me! 👍 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See notes in commit message.
As bdb seems a little bit broken and no issues exist/are linked for
the actual issues, I removed a couple of things that are outdated
(e.g. the symtab) and turned them into a TODO (snitch-ing required).
This makes bdb at least usable and not fail at startup, trying to find
the symbol table. Also, I stole some code from bme to load the native
write implementation, such that the virtual machine throws an error
when stepping into native write instruction.
Might fix #100 (not sure whether we can remove it)