Skip to content

(#457) Variable shadowing warning #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rexim merged 3 commits into from
Jun 25, 2021
Merged

(#457) Variable shadowing warning #479

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc2fcd7
(#457) Variable shadowing warning
rexim Jun 25, 2021
89fb924
Add TODO(#480)
rexim Jun 25, 2021
8310436
Add TODO(#481)
rexim Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions bang/src/bang_compiler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,14 +702,32 @@ void compile_var_def_into_basm(Bang *bang, Basm *basm, Bang_Var_Def var_def, Ban
exit(1);
}

Compiled_Var *existing_var = bang_scope_get_compiled_var_by_name(bang->scope, var_def.name);
if (existing_var) {
fprintf(stderr, Bang_Loc_Fmt": ERROR: variable `"SV_Fmt"` is already defined\n",
Bang_Loc_Arg(var_def.loc),
SV_Arg(var_def.name));
fprintf(stderr, Bang_Loc_Fmt": NOTE: the first definition is located here\n",
Bang_Loc_Arg(existing_var->def.loc));
exit(1);
// Existing Var Error
{
Compiled_Var *existing_var = bang_scope_get_compiled_var_by_name(bang->scope, var_def.name);
if (existing_var) {
fprintf(stderr, Bang_Loc_Fmt": ERROR: variable `"SV_Fmt"` is already defined\n",
Bang_Loc_Arg(var_def.loc),
SV_Arg(var_def.name));
fprintf(stderr, Bang_Loc_Fmt": NOTE: the first definition is located here\n",
Bang_Loc_Arg(existing_var->def.loc));
exit(1);
}
}

// TODO(#480): bang does not warn about unused variables

// Shadowed Var Warning
{
// TODO(#481): bang has no option to treat warnings as errors
Compiled_Var *shadowed_var = bang_get_compiled_var_by_name(bang, var_def.name);
if (shadowed_var) {
fprintf(stderr, Bang_Loc_Fmt": WARNING: variable `"SV_Fmt"` is shadowing another variable with the same name\n",
Bang_Loc_Arg(var_def.loc),
SV_Arg(var_def.name));
fprintf(stderr, Bang_Loc_Fmt": NOTE: the shadowed variable is located here\n",
Bang_Loc_Arg(shadowed_var->def.loc));
}
}

Compiled_Var new_var = {0};
Expand Down