Skip to content

Fixed MessageCallback error message while MINGW building. #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BillKek wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixed MessageCallback error message while MINGW building. #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
996c51c
MINGW build fix
BillKek Jul 20, 2021
86d5b7e
Adds reporting about Error while build.
BillKek Jul 20, 2021
cb68e2e
try to get logs from bat-execution
BillKek Jul 20, 2021
fa12bd0
msys2 and cmd works same with windows batch file.
BillKek Jul 20, 2021
bdb84e2
Fixed. Magic prefix ./ added.
BillKek Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,16 @@ jobs:
msys2 -c 'pacman --noconfirm -Suu'
- name: debug build
run: |
build_msys2.bat
shell: cmd
./build_msys2.bat
shell: msys2 {0}
env:
CC: gcc
CXX: g++
PATH: D:\a\_temp\msys\msys64\usr\bin;D:\a\_temp\msys\msys64\${{ matrix.msystem_lower }}\bin;D:\a\_temp\msys
- name: release build
run: |
build_msys2.bat --release
shell: cmd
./build_msys2.bat --release
shell: msys2 {0}
env:
CC: gcc
CXX: g++
Expand Down
4 changes: 3 additions & 1 deletion build_msys2.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ if defined SOMETHING_RELEASE (
config_indexer assets/vars.conf >src/config_index.hpp
%CXX% %CXXFLAGS% %PKGSCFLAGS% -o something.debug.exe src/something.cpp %PKGLIBS% -lopengl32 -static
)
dir *.exe
REM Returns Errorcode. Zero is Noerror.
EXIT /B %ERRORLEVEL%
endlocal

dir *.exe
21 changes: 14 additions & 7 deletions src/something_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,20 @@ const Seconds DELTA_TIME_SECS = 1.0f / static_cast<Seconds>(SCREEN_FPS);
const Milliseconds DELTA_TIME_MS =
static_cast<Milliseconds>(floorf(DELTA_TIME_SECS * 1000.0f));

void MessageCallback(GLenum source,
GLenum type,
GLuint id,
GLenum severity,
GLsizei length,
const GLchar* message,
const void* userParam)
// inspired by https://github.com/Velho/ded/commit/44f9223d6ea7278243fa56c5a0c095bba0db4450
#if defined(__MINGW32__) || defined(__MINGW64__)
#define CALLING_METHOD __stdcall
#else
#define CALLING_METHOD
#endif

void CALLING_METHOD MessageCallback(GLenum source,
GLenum type,
GLuint id,
GLenum severity,
GLsizei length,
const GLchar* message,
const void* userParam)
{
(void) source;
(void) id;
Expand Down