refactor(env-setup): unify daemon install under services, drop container variant#25
Merged
AndriiTsok merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
…ainer variant
The container-based `services` block (docker run of postgres/redis/nats/
mysql/mongo per config) was never used by any consumer — mcpg-dev/source-code
uses the binary-install pattern exclusively. The split between
`test_binaries` (binary on PATH) and `services` (containerized daemon)
confused consumers and added maintenance surface for the unused branch.
Unified name. `services` now means "install these daemon binaries on PATH":
services:
redis: true
nats: true
Changes:
- schema: old container-shape `services` deleted; boolean-keyed version
replaces `test_binaries`.
- parser: drops services_json / service_names / setup_services outputs;
emits `service_redis` + `service_nats` booleans.
- action.yml: drops the ~130-line container-start step entirely. Install
steps renamed from test_binary_* conditions to service_* and from
"TEST BINARIES" heading to "SERVICES". Output declarations + summary
step updated.
- self-test: setup_services assertion dropped; skip list no longer
includes "services" (it's gated per-key in the config itself).
Breaking for any external consumer that set `services:` to a container
config. Nothing in mcpg-dev/source-code uses that shape. Tagging v1.5.0
after merge; downstream consumer PR swaps `test_binaries:` to `services:`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The container-based
servicesblock (docker run of postgres/redis/nats/mysql/mongo) had zero consumers. Meanwhile v1.4.0 addedtest_binariesfor the binary-install pattern that's actually used. Two overlapping blocks, one used, one dead — delete the dead one and reclaim the natural name for the live one.What the new
serviceslooks likeBoolean-keyed. Means "install this daemon binary on PATH so tests can spawn it". No containers, no env plumbing, no healthcheck plumbing — tests control the lifecycle.
Breaking change
Any external consumer that had
services:set to the old container shape stops working.mcpg-dev/source-codedoesn't use it; I'll bump the consumer PR (#22 in mcpg-dev) to useservices:instead oftest_binaries:right after this tags v1.5.0.Self-test
Polyglot fixtures don't use
services, so no fixture migration. The skip-all test removedservicesfrom its skip list (field is gated per-key now). Assertion checkingsetup_services=falsereplaced withservice_redis=false/service_nats=false.🤖 Generated with Claude Code