Skip to content

Conversation

@pruby
Copy link

@pruby pruby commented Mar 2, 2014

When changing the config, I forgot that it has to be done in two places. This should fix it and stop it getting stomped over by the config generator.

@ttk2
Copy link
Owner

ttk2 commented Mar 3, 2014

sounds good, Also need a pull adding the new 1.7.2 factories here.

On Sun, Mar 2, 2014 at 3:43 PM, Tim Goddard notifications@github.comwrote:

When changing the config, I forgot that it has to be done in two places.

This should fix it and stop it getting stomped over by the config generator.

You can merge this Pull Request by running

git pull https://github.com/pruby/FactoryMod-1 reduce_press_costs_backport

Or view, comment on, or merge it at:

#4
Commit Summary

  • Add printing press config changes to the config template

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/4
.

@pruby
Copy link
Author

pruby commented Mar 3, 2014

Had a look there and backported a config, but looks like the author of those changes has made the same mistake I did, updated config.yml without updating the entries in "Config Scripts". Flicked a message back to them in group.

ttk2 added a commit that referenced this pull request Mar 4, 2014
Add printing press config changes to the config template
@ttk2 ttk2 merged commit 516fa39 into ttk2:master Mar 4, 2014
@ttk2
Copy link
Owner

ttk2 commented Mar 4, 2014

ok, merging, we can get the new factories in after another pull.

@pruby pruby deleted the reduce_press_costs_backport branch March 5, 2014 00:49
@ttk2 ttk2 mentioned this pull request Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants