Conversation
- Require 'Authorization: Bearer <token>' header or '?token=<token>' query param - Validate against configured token using constant-time comparison - Reject unauthorized connections in onOpen - Updated GatewayE2ETest to send auth headers
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Add GATEWAY_AUTH_TOKEN and GATEWAY_PORT environment variable support. - Bind GatewayServer to 0.0.0.0 for container compatibility. - Optimize authenticated client lookups using a Set. - Improve query parameter token extraction robustness. - Add null safety for gateway configuration.
| } catch (NumberFormatException ignored) { | ||
| } |
There was a problem hiding this comment.
🟡 Silent failure on invalid GATEWAY_PORT environment variable
When GATEWAY_PORT is set to a non-numeric value (e.g., GATEWAY_PORT=abc), the NumberFormatException is silently caught and ignored, leaving the port at its default value without any indication to the user.
Impact and Details
At ConfigLoader.java:44, the catch block is empty:
} catch (NumberFormatException ignored) {
}This means if a user sets GATEWAY_PORT=abc or GATEWAY_PORT=99999, the application will silently use the default port (18789) instead. The user would have no way to know their configuration was ignored, potentially leading to port conflicts or the application listening on an unexpected port. At minimum, this should log a warning.
| } catch (NumberFormatException ignored) { | |
| } | |
| } catch (NumberFormatException e) { | |
| System.err.println("WARNING: Invalid GATEWAY_PORT value '" + envPort + "', using default port"); | |
| } |
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Uh oh!
There was an error while loading. Please reload this page.