Feature/scalable agent loop

[tuhinkanti]

---

[devin-ai-integration]

Devin Review found 4 new potential issues.

View 15 additional findings in Devin Review.

[devin-ai-integration]

🔴 Context truncation inserts a 'user' notice that can create consecutive user messages, violating Anthropic API alternation requirement

When context truncation occurs, a synthetic user message is prepended to the truncated messages. If the first retained message also has role user, this creates two consecutive user messages, violating the Anthropic API requirement that messages must alternate between user and assistant roles.

Root Cause

At AgentExecutor.java:171-173:

Message notice = new Message("user",
    "[System: " + dropped + " earlier messages were truncated ...]");
truncated.add(0, notice);

The truncation works by keeping the N most recent messages that fit the token budget. In a normal conversation, the most recent messages start from the end. If the first kept message is a user message (which is common — e.g., the user just sent a prompt), prepending another user message creates two consecutive user messages.

After adding the system message at line 177, the final context looks like: [system, user(notice), user(original), ...]. The Anthropic API will reject this with a 400 error because it requires strict role alternation.

Impact: Context truncation in many common scenarios will cause the next API call to fail.

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

Devin Review found 3 new potential issues.

View 17 additional findings in Devin Review.

[devin-ai-integration]

🔴 Extra fi in entrypoint.sh causes shell syntax error, preventing Docker container startup

The entrypoint.sh script has an unmatched fi on line 27, which causes a bash syntax error that prevents the Docker container from starting.

Root Cause

The shell structure is:

• Line 7: if [ -d /certs ] && ....; then
• Line 8: for bundle in /certs/*.crt; do
• Line 14: for pem in /tmp/cert-*.pem; do
• Line 24: done (closes inner for pem)
• Line 25: done (closes outer for bundle)
• Line 26: fi (closes the if from line 7)
• Line 27: fi ← extra/unmatched, causes syntax error

Verified with bash -n entrypoint.sh:

entrypoint.sh: line 27: syntax error near unexpected token `fi'

Impact: The Docker container will fail to start entirely because set -e is enabled and the entrypoint script cannot be parsed. This blocks all Docker-based deployments.

Suggested change

fi

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

🔴 Concurrent session access via non-thread-safe ArrayList after gateway dispatches to virtual threads

The GatewayServer.onMessage now dispatches requests to virtual threads via agentExecutor.submit(), but Session.messages is a plain ArrayList with no synchronization, enabling concurrent modification.

Root Cause

Before this PR, GatewayServer.onMessage() processed requests synchronously. Now at src/main/java/ai/openclaw/gateway/GatewayServer.java:97, it dispatches to a virtual thread pool:

agentExecutor.submit(() -> { ... });

This means two WebSocket messages for the same session can run agentExecutor.execute(sessionId, message) concurrently. Inside, execute() calls sessionStore.appendMessage() which calls session.addMessage() at src/main/java/ai/openclaw/session/Session.java:76-78:

public void addMessage(Message message) {
    this.messages.add(message); // ArrayList - not thread-safe
    this.lastActiveAt = Instant.now();
}

Meanwhile, buildContext() at src/main/java/ai/openclaw/agent/AgentExecutor.java:154 iterates over session.getMessages() which returns the same ArrayList reference. Concurrent reads and writes to ArrayList can cause ConcurrentModificationException, ArrayIndexOutOfBoundsException, or silent data corruption.

Impact: Under concurrent requests for the same session (now possible via WebSocket virtual thread dispatch or simultaneous Slack + WebSocket requests), the session's message list can be corrupted, causing crashes or lost messages.

Prompt for agents

The Session.messages field (src/main/java/ai/openclaw/session/Session.java) is a plain ArrayList that is now accessed concurrently due to the GatewayServer dispatching to virtual threads. Either:
1. Change Session.messages to a thread-safe list (e.g., Collections.synchronizedList or CopyOnWriteArrayList) in Session.java, and synchronize iteration in AgentExecutor.buildContext()
2. Or add session-level locking in AgentExecutor.execute() to serialize access per session ID

Both Session.java (constructor and setMessages) and AgentExecutor.java (buildContext iterating session.getMessages()) need to be updated.

---

Was this helpful? React with 👍 or 👎 to provide feedback.